I have created a new general in Generals, (not Zero hour). In skirmish mode, everything works fine until the game is over and I have defeated the enemy, but the game will not end. I have to exit the game to finish it.

I have added my new general to the generals.csf so the general works in skirmish mode
I have tried editing the Multiplayerscripts.scb adding my new generals faction but this makes no difference, any help would be very welcome.

Does the game shows you the defeated screen and sound?

---

No, nothing happens after it says the enemy is defeted. I have to exit the game to win. I think it's because there is no script for my new general, but I'm not sure.

Your exactly right, you need to add the correct victory/defeat scripts to the Skirmish/Multiplayer scripts.
Unfortunately I can't remember the details of the exact scripts you need to add in so I can't be of any help. Sorry 😞

Additionally:
If you don't have EVA upgrade sounds you may have to add in your factions details to the Eva.ini

I have already done the Eva.ini, but thanks for trying to help. It must be the Multplayerscript.scb, because there is no mention of Victory or Defeat in the Skirmishscripts.scb.

I have been working on something similar to yours for some time, basically my aim was to add the AirGen from ZH into generals. It didn't go as well as I thought it would due to tech errors.

Anyway, my point is that it was much easier to sort out my problem as I could just use the associated scripts from ZH's .scb files. Since you can't just copy scripts from one game and paste them it's gonna be much harder for you. You might even have to open existing scripts from ZH (or generals, whatever your modding) and try to copy/modify them for your new faction. I havn't had much experience on the matter, I had a vague idea of my problem when I came to it but mostly followed "CommieDog" and "Me Myself and Pi's" steps.

Since "Me Myself and Pi" left the forum sometime ago, you should wait for CommieDog to come along, he's knows alot about ZH and generals.

Working with MultiplayerScripts.scb is fairly straightforward. I don't know what Sky demon is worried about, as there really isn't any need to port scripts from ZH to get Generals to recognize a new faction.

---

This is what I have already tried, also if I let the computer side win the game does'nt end either.

*** IF ***
Everything belonging to the local player has been destroyed, but his allies may or may not have been defeated.
*AND* Player '' is Faction Name: Boss
*** THEN ***
Set timer 'MultiplayerPersonalDefeatDeclare' to expire in 6.00 seconds.
Play 'End_Chi_Failure' using fadeout (TRUE) and fadein (TRUE).

*** IF ***
Timer 'MultiplayerPersonalDefeatSound' has expired.
*AND* Player '' is Faction Name: Boss
*** THEN ***
'EvaChina_Defeat' plays, allowing overlap FALSE (true to allow, false to disallow).

*** IF ***
Timer 'MultiplayerPersonalDefeatDeclare' has expired.
*** THEN ***
Show 'Game Over' window

*** IF ***
Timer 'MultiplayerPersonalDefeatDeclare' has expired.
*AND* 'End_Chi_Failure' has completed at least 1 times. (NOTE: This can only be used to start other music. USING THIS SCRIPT IN ANY OTHER WAY WILL CAUSE REPLAYS TO NOT WORK.)
*** OR ***
Timer 'MultiplayerPersonalDefeatDeclare' has expired.
*AND* 'End_GLA_Failure' has completed at least 1 times. (NOTE: This can only be used to start other music. USING THIS SCRIPT IN ANY OTHER WAY WILL CAUSE REPLAYS TO NOT WORK.)
*** OR ***
Timer 'MultiplayerPersonalDefeatDeclare' has expired.
*AND* 'End_USA_Failure' has completed at least 1 times. (NOTE: This can only be used to start other music. USING THIS SCRIPT IN ANY OTHER WAY WILL CAUSE REPLAYS TO NOT WORK.)
*** THEN ***
Play 'Game_Silent' using fadeout (TRUE) and fadein (TRUE).

*** IF ***
The multiplayer game has ended in defeat for the local player and his allies.
*AND* Player '' is Faction Name: boss
*** THEN ***
Set timer 'MultiplayerDefeatSound' to expire in 5.00 seconds.
Set timer 'MultiplayerDefeatDeclare' to expire in 6.00 seconds.
Play 'End_Chi_Failure' using fadeout (TRUE) and fadein (TRUE).

*** IF ***
Timer 'MultiplayerDefeatSound' has expired.
*AND* Player '' is Faction Name: boss
*** THEN ***
'EvaChina_Defeat' plays, allowing overlap FALSE (true to allow, false to disallow).

*** IF ***
Timer 'MultiplayerDefeatDeclare' has expired.
*** THEN ***
Show 'Defeated' window and end game

*** IF ***
The multiplayer game has ended in victory for the local player and his allies.
*AND* Player '' is Faction Name: boss
*** THEN ***
Set timer 'MultiplayerVictoryChinaVoice' to expire in 4.00 seconds.
Set timer 'MultiplayerVictoryCheer' to expire in 5.00 seconds.
Set timer 'MultiplayerVictoryDeclare' to expire in 6.00 seconds.
Play 'End_Chi' using fadeout (TRUE) and fadein (TRUE).

*** IF ***
Timer 'MultiplayerVictoryChinaVoice' has expired.
*** THEN ***
'EvaChina_Victory' plays, allowing overlap TRUE (true to allow, false to disallow).